6,534
edits
Changes
→diff-security-ipid-20060324: whitespace fixes; pre -> source
<div class="change">
Patch from Alexey Kuznetsov <alexey@openvz.org>:<br/>
[TCP]: Do not use inet->id of global tcp_socket when sending RST.<br/>
The problem is in ip_push_pending_frames(), which uses:<br/> <presource lang="c"> if (!df) { __ip_select_ident(iph, &rt->u.dst, 0); } else { iph->id = htons(inet->id++); }</presource>instead of ip_select_ident().<br/>
Right now I think the code is a nonsense. Most likely, I copied it from
old ip_build_xmit(), where it was really special, we had to decide
whether to generate unique ID when generating the first (well, the last)
fragment.<br/>
In ip_push_pending_frames() it does not make sense, it should use plain
ip_select_ident() instead.<br/>
Signed-off-by: David S. Miller <davem@davemloft.net>
</div>
==== diff-smp-nmi-show-regs ====
<div class="change">
